Fix IO FAT selected-IED context, grid layout, and evidence safety - #126
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f27b25254
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var preparation = await engineeringWindow.PrepareIoTestIedForFatAsync( | ||
| Project, | ||
| selectedIed, | ||
| progress); |
There was a problem hiding this comment.
When a mixed IED contains a completed signal that is no longer available in the live model, this preparation call still includes it because completed points remain enabled until immediately before Session.Start. PrepareIoTestIedForFatAsync snapshots every enabled point (MainWindow.IoTesting.AutoConnect.cs:24-26) and fails unless all requested points become live (MainWindow.IoTesting.AutoConnect.cs:203-213), so the method returns before pending, otherwise-valid rows can resume. Apply the protected-row scope during preflight and preparation as well as during Session.Start.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in fa5bcfab with regression coverage in 84139315. Completed evidence rows are now disabled before preflight, remain excluded through PrepareIoTestIedForFatAsync and Session.Start, and are restored only in the outer finally. This allows mixed-progress continuation even when a completed legacy row is no longer present in the live model.
1 participant
Ringkasan
Perbaikan workspace IO List FAT berdasarkan audit layout multi-IED:
✔ PASSpada card IED ketika seluruh test point aktif sudah PASS.COMPLETEDyang ambigu dari toolbar workspace.Safety behavior
TestEnabledyang sementara diubah selalu dikembalikan melaluifinally.Validation
Regression contract tests ditambahkan untuk selected-IED context, lokasi preview toggle, balanced grid widths, centered relay headers, PASS card badge, dan evidence protection flow.